remove references to jvm-build-service #1766
Open
+3,359
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnevrlka
force-pushed
the
remove-jvm-build-service
branch
from
36cc05c to
be37461
Compare
My favourite approach is this:
This also works beautifully with rebasing on main. If buildah/0.2 changes in the meantime, you just fix the first commit by running |
tnevrlka
force-pushed
the
remove-jvm-build-service
branch
2 times, most recently
from
08dcf4e to
c325e83
Compare
chmeliik
reviewed
Dec 20, 2024
task/buildah-oci-ta/0.3/MIGRATION.md
Outdated
|
|
||
| Removes references to `jvm-build-service` | ||
| * Removes `analyse-dependencies-java-sbom` step | ||
| * Removes `SBOM_JAVA_COMPONENTS_COUNT` and `JAVA_COMMUNITY_DEPENDENCIES` results |
There was a problem hiding this comment.
(similarly for the other migrations)
|
Could you also update https://github.com/konflux-ci/build-definitions/blob/main/.github/workflows/temp-block-buildah.yaml to also check the 0.3 yaml? It appears that the check is still relevant, no updates on https://issues.redhat.com/browse/KONFLUX-5706 😞 |
tnevrlka
force-pushed
the
remove-jvm-build-service
branch
3 times, most recently
from
4e5729d to
b7713d2
Compare
- Buildah 0.3 will be released - Copy buildah 0.2 directory to 0.3 for easier diff comparisons between the versions
- jvm-build-service is not used by anyone and will get reworked - buildah task contains references to jvm-build-service - Removal of the references is a breaking change * Remove `analyse-dependencies-java-sbom` step * Remove `SBOM_JAVA_COMPONENTS_COUNT` result * Remove `JAVA_COMMUNITY_DEPENDENCIES` result - Release buildah version 0.3
tnevrlka
force-pushed
the
remove-jvm-build-service
branch
from
b7713d2 to
d978eb9
Compare
- Buildah task has been upgraded to 0.3 - Upgrade the oci-ta and remote tasks too
- There is a check ensuring that the size buildah-remote-oci-ta doesn't increase - It only works for version 0.2, make it work for 0.3 too
- Buildah task has been updated to 0.3 - Make docker-build pipelines use the new version
tnevrlka
force-pushed
the
remove-jvm-build-service
branch
from
d978eb9 to
782d4cf
Compare
tisutisu
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analyse-dependencies-java-sbomstepSBOM_JAVA_COMPONENTS_COUNTresultJAVA_COMMUNITY_DEPENDENCIESresultNote for reviewers:I haven't found an easy way to compare different files in GitHub, I would probably checkout the branch locally and do something like:(I welcome different ideas)